I've recently upgraded to Comments Preview v1.0 and have encountered a couple of problems:
1. For a post where comments are closed, the sidebar disappears. For an example, see the "Testing, testing 1 2 3" post at my test site http://sairuh.org/
In fact, if I disable all plugins but Comments Preview, all single posts pages for posts with closed comments appear blank.
2. For a post where comments are open, when I click on the Preview button the resulting page is either blank (eg, my local test server), or contains a fatal PHP error. The latter can be seen when testing Comments Preview with the "Filosofo Comments Preview" post at my test site (again at http://sairuh.org/).
Is there something I need to modify in either my theme's comments.php file, or in your plugin file? My sairuh.org test site is using the Blogtxt theme, whereas my local site is using VeryPlainTxt --both available from http://plaintxt.org/
For 1:
You're getting a fatal error from your sidebar, independent of my plugin, and it may be contributing to the problem. (Fatal error: Call to undefined function g2_sidebargridblock() in /. . ./wp-content/themes/blogtxt/sidebar.php/ on line 31)
That's the way the old versions of the plugin worked, but now it should point elsewhere. Let the plugin change the path automatically; put back in the path to wp-comments-post.php, and remove the comented out version you have before the actual form, as that might confuse the plugin's attempt to replace the text.
Thanks for your quick reply! I fixed #2 by reverting to the original comments.php for the themes.
On a related note, I had to fix keyboard navigation by changing the tabindex values in the submitbuttons() function of filosofo-comments-preview.php to 7 and 8 for the preview and submit buttons, respectively. That tweak just might be specific to PlainTxt.org themes, though.
I'm still experiencing #1. If I turn off your plugin, the sidebar reappears for single post pages with closed comments. I think the error was because I had the WPG2 plugin turned off, and sidebar.php has a call to it which results in that error when it's off. On http://sairuh.org/ I've turned on both WPG2 and Comments Preview, and you can see the disappearing sidebar issue.
Btw, I really like how the preview now appears inline on the post page, without generating another page. Very streamlined, very cool!
The problem was that the output buffer wasn't being flushed, because I was doing it in the comment_form action hook which was not present when comments were closed.
Hello!
I've recently upgraded to Comments Preview v1.0 and have encountered a couple of problems:
1. For a post where comments are closed, the sidebar disappears. For an example, see the "Testing, testing 1 2 3" post at my test site http://sairuh.org/
In fact, if I disable all plugins but Comments Preview, all single posts pages for posts with closed comments appear blank.
2. For a post where comments are open, when I click on the Preview button the resulting page is either blank (eg, my local test server), or contains a fatal PHP error. The latter can be seen when testing Comments Preview with the "Filosofo Comments Preview" post at my test site (again at http://sairuh.org/).
Is there something I need to modify in either my theme's comments.php file, or in your plugin file? My sairuh.org test site is using the Blogtxt theme, whereas my local site is using VeryPlainTxt --both available from http://plaintxt.org/
Thanks in advance!
P.S. I'm running WP 2.1.3.
For 1:
You're getting a fatal error from your sidebar, independent of my plugin, and it may be contributing to the problem. (Fatal error: Call to undefined function g2_sidebargridblock() in /. . ./wp-content/themes/blogtxt/sidebar.php/ on line 31)
For 2:
It looks like your comments.php file has been modified so that the form points to the plugin itself (
<form action="http://sairuh.org/wp-content/plugins/filosofo-comments-preview.php).That's the way the old versions of the plugin worked, but now it should point elsewhere. Let the plugin change the path automatically; put back in the path to wp-comments-post.php, and remove the comented out version you have before the actual form, as that might confuse the plugin's attempt to replace the text.
Thanks for your quick reply! I fixed #2 by reverting to the original comments.php for the themes.
On a related note, I had to fix keyboard navigation by changing the tabindex values in the submitbuttons() function of filosofo-comments-preview.php to 7 and 8 for the preview and submit buttons, respectively. That tweak just might be specific to PlainTxt.org themes, though.
I'm still experiencing #1. If I turn off your plugin, the sidebar reappears for single post pages with closed comments. I think the error was because I had the WPG2 plugin turned off, and sidebar.php has a call to it which results in that error when it's off. On http://sairuh.org/ I've turned on both WPG2 and Comments Preview, and you can see the disappearing sidebar issue.
Btw, I really like how the preview now appears inline on the post page, without generating another page. Very streamlined, very cool!
Sairuh,
I emailed you an updated copy of the plugin that should fix the problem. Will you try it out and let me know?
Thanks.
The test plugin you sent me works: the sidebar is back, single.php pages with closed comments display fine now. Thanks!
Out of curiosity, what was the issue you fixed?
Thanks for testing it for me.
The problem was that the output buffer wasn't being flushed, because I was doing it in the comment_form action hook which was not present when comments were closed.
Whups: When I installed v1.0.1 of the plugin onto my iwaruna.com site, I get the following error after I hit the Preview button in a comment form:
Fatal error: Call to a member function get_var() on a non-object in /[path_removed]/wp-content/plugins/filosofo-comments-preview.php on line 33
Any idea why this is occurring? I'm using a customized version of another plaintxt.org theme, VeryPlainTxt.
For now I'll use v0.78 of your plugin on that site. However, do let me know what I can check or change to debug and fix this.
Thanks again!
i think this is the same problem as #2 in your first post in this thread.
[thwaps side of the head] Doh, of course! I need to remember that your updates made my theme code more simplified. :)
Thanks again!
RSS feed for this topic
Reply
You must log in to post.